Correct capitalization and punctuation in guidelines#118
Open
tacman wants to merge 1 commit intojolicode:mainfrom
Open
Correct capitalization and punctuation in guidelines#118tacman wants to merge 1 commit intojolicode:mainfrom
tacman wants to merge 1 commit intojolicode:mainfrom
Conversation
lyrixx
reviewed
Nov 5, 2025
| - you MUST follow PSR2 and Symfony coding standard (run `composer cs` on your branch); | ||
| - you MUST run the tests (run `composer test`); | ||
| - you MUST comply to the MIT license; | ||
| - You MUST write code in English. |
Member
There was a problem hiding this comment.
Why did you change the ; to a .?
We always learn we should use ; 🤔
For example, on symfony.com, the use the same pattern!
Author
There was a problem hiding this comment.
This is what claude tells me:
Most modern writing style guides (AP, Chicago Manual of Style for web content, etc.) recommend either:
No punctuation after bullets if they're phrases
Periods if they're complete sentences
Consistent punctuation throughout the list
The semicolon approach is becoming less common except in very formal or legal contexts.
To my eye, the ; looks odd, and in particular with the last bullet ending in a period.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.